Messages in this thread | | | Date | Wed, 7 Mar 2012 13:06:13 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCHv7] EDAC core changes in order to properly report errors from all types of memory controllers |
| |
On Wed, Mar 07, 2012 at 08:36:12AM -0300, Mauro Carvalho Chehab wrote: > >> - 1 patch that adds a trace event to report memory errors: > >> events/hw_event: Create a Hardware Events Report Mecanism (HERM) > > > > NACK to that last one. > > Hmm... interesting... this one adds a tracepoint for non-MCA based memory errors... > I've understood that you've against only the mca one...
If you mean the patch at
http://git.kernel.org/?p=linux/kernel/git/mchehab/linux-edac.git;a=commitdiff;h=56efd647f5a63497a07caaa22e993307aaf95270
where you've removed the trace.*mce call, then I don't object to it per se. Send it for proper review too, though, because it contains incorrect comments like
+ * Those events are generated when hardware detected a corrected or + * uncorrected event, and are meant to replace the current API to report + * errors defined on both EDAC and MCE subsystems.
which clearly need fixing.
Thanks.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |