Messages in this thread | | | From | Axel Lin <> | Date | Wed, 7 Mar 2012 12:16:37 +0800 | Subject | Re: [PATCH] regulator: Rename s5m8767_convert_voltage to s5m8767_get_proper_voltage_sel |
| |
2012/3/7 Axel Lin <axel.lin@gmail.com>: > This function finds the smallest voltage that falls within the specified range, > and then returns the selector. This rename makes the intention more clear. > > Also remove unneeded local variables min_vol and max_vol in s5m8767_set_voltage > and s5m8767_set_voltage_buck. > > Signed-off-by: Axel Lin <axel.lin@gmail.com> > --- > I was confused by the function name, s5m8767_convert_voltage() converts what to what? >
BTW, I'm also confused by s5m8767_set_high and s5m8767_set_low functions. Both function sets the same gpios to the same state. ( by different order ) Maybe we need comments (or rename) for both functions.
Regards, Axel
| |