Messages in this thread | | | From | Mike Frysinger <> | Subject | Re: [PATCH 1/3] Kbuild: centralize MKIMAGE and cmd_uimage definitions | Date | Tue, 6 Mar 2012 22:56:07 -0500 |
| |
On Tuesday 06 March 2012 19:30:36 Stephen Warren wrote: > --- a/arch/blackfin/boot/Makefile > +++ b/arch/blackfin/boot/Makefile > > +ifeq ($(CONFIG_RAMKERNEL),y) > +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) > +else # CONFIG_ROMKERNEL must be set > +UIMAGE_LOADADDR = $(CONFIG_BOOT_LOAD) > +endif
this part is wrong :). the else branch should be $(CONFIG_ROM_BASE).
> +UIMAGE_ENTRYADDR = $(shell $(NM) vmlinux | awk '$$NF == "__start" {print > $$1}')
i feel like if we tried harder, we could automate the -e arg for all arches. i understand if you don't want to undertake that though. -mike [unhandled content-type:application/pgp-signature] | |