Messages in this thread | | | Date | Tue, 6 Mar 2012 16:15:43 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] selinux: init target class when add avc callback |
| |
On Wed, 07 Mar 2012 07:59:30 +0800 Wanlong Gao <gaowanlong@cn.fujitsu.com> wrote:
> On 02/05/2012 09:53 AM, Wanlong Gao wrote: > > > Target security class should be initialized when add avc callback. > > Although tclass is userless in callbacks now, but it may be used > > in the future . > > > > Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com> > > --- > > security/selinux/avc.c | 1 + > > 1 files changed, 1 insertions(+), 0 deletions(-) > > > > diff --git a/security/selinux/avc.c b/security/selinux/avc.c > > index dca1c22..27495e6 100644 > > --- a/security/selinux/avc.c > > +++ b/security/selinux/avc.c > > @@ -576,6 +576,7 @@ int avc_add_callback(int (*callback)(u32 event, u32 ssid, u32 tsid, > > c->events = events; > > c->ssid = ssid; > > c->tsid = tsid; > > + c->tclass = tclass; > > c->perms = perms; > > c->next = avc_callbacks; > > avc_callbacks = c;
Perhaps James can take a look at this?
avc_add_callback() looks a bit odd. It uses GFP_ATOMIC, but that is unnecessary because avc_add_callback() is only ever called from module_init() code. And if it isn't only ever called from module_init() code then it needs some locking for that list.
| |