Messages in this thread | | | Date | Sat, 31 Mar 2012 10:49:08 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH v3 0/4] tools: Add a toplevel Makefile |
| |
* Borislav Petkov <bp@amd64.org> wrote:
> On Fri, Mar 30, 2012 at 07:26:05AM +0200, Sam Ravnborg wrote: > > > $ make tools/<toolname> tinstall > > But this makes no sense. > > > > It would be better to be consistent - so the user does not need to remember > > when to add a space and when not. > > > > make tools/<command> where <command> is one of help, install, clean, "nothing" > > make tools/<toolname> > > make tools/<toolname>_<comand> where command is the same set of commands > > > > > > then a user could do: > > > > make tools/clean > > make tools/perf > > make tools/perf_install > > > > or > > > > make tools/clean > > make tools/ > > make tools/install > > This one I had hard time imagining: who would install all > tools but I guess it could have it's use...
regression testing?
> > The install target could implicitly include the build > > target. > > > > With this scheme the user is up to less suprises. > > > > All the above are only minor adjustments compared to what > > you already did. bt the consistency here is a gain (IMO). > > ... but yeah, those make sense to me too, let's see what the > others think, Arnaldo, Ingo?
Well, if Sam and Michal are fine with it I'm a happy camper.
One question. Instead of:
make tools/perf_install
Couldnt we beat kbuild into submission to allow the much more obvious:
make tools/perf install
?
I don't think anyone would expect the *kernel* to be installed in such a circumstance - so it's only a question of making the Makefile understand it, right?
Thanks,
Ingo
| |