Messages in this thread | | | Subject | Re: [linux-pm] [PATCH 17/76] thermal_sys: convert printks to pr_<level> | From | Joe Perches <> | Date | Fri, 30 Mar 2012 12:08:50 -0700 |
| |
On Fri, 2012-03-30 at 16:41 +0300, Eduardo Valentin wrote: > On Fri, Mar 30, 2012 at 06:13:20AM -0400, Len Brown wrote: > > From: Joe Perches <joe@perches.com> > > Use the current logging style. [] > We should get the struct dev in thermal_zone_device, I think it makes > more sense to use the dev_* helper functions. [] > The orig argument could probably be changed to a thermal zone device > and the we use it's id as orig for the message. > What do you think?
dev_<level> should be used instead of pr_<level> when an appropriate struct device * is available.
cheers, Joe
| |