Messages in this thread | | | Date | Fri, 30 Mar 2012 14:33:46 +0200 (CEST) | From | Joel Reardon <> | Subject | Re: [PATCH] UBI: allow atomic updates to sychronously erase old PEB |
| |
Just for 'blocking', or also all the 'erase's.
cheers, Joel Reardon
On Fri, 30 Mar 2012, Artem Bityutskiy wrote:
> On Fri, 2012-03-30 at 14:20 +0200, Joel Reardon wrote: > > Hey, > > > > If there's a power cut after the new version is written and the old one is > > erased, then it is my understanding that while remounting UBI will detect > > that the old version is not needed and put it on the erase queue. > > Yes. > > > The > > higher layer that issued the call to update the block will have to do a > > blocking clear of the ubi erase queue when remounting after unsafely > > unmounting. > > Yes. You can do this if the security is enabled, I think, using > 'ubi_sync()'. > > I did not have time to look at your patches, but one quick comment is > that we usually call the argument which controls whether the function > has to wait for the operation to complete or not 'sync', could you > please follow this unwritten convention as well? > > -- > Best Regards, > Artem Bityutskiy >
| |