lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 21/76] thermal: Fix for setting the thermal zone mode to enable/disable
    Date
    From: Amit Daniel Kachhap <amit.kachhap@linaro.org>

    Basically without this patch changing the mode of thermal zone
    is not possible as wrong string size is passed to strncmp.

    Signed-off-by: Amit Daniel Kachhap <amit.kachhap@linaro.org>
    Acked-by: Jean Delvare <khali@linux-fr.org>
    Signed-off-by: Len Brown <len.brown@intel.com>
    ---
    drivers/thermal/thermal_sys.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c
    index fab970d..022bacb 100644
    --- a/drivers/thermal/thermal_sys.c
    +++ b/drivers/thermal/thermal_sys.c
    @@ -150,9 +150,9 @@ mode_store(struct device *dev, struct device_attribute *attr,
    if (!tz->ops->set_mode)
    return -EPERM;

    - if (!strncmp(buf, "enabled", sizeof("enabled")))
    + if (!strncmp(buf, "enabled", sizeof("enabled") - 1))
    result = tz->ops->set_mode(tz, THERMAL_DEVICE_ENABLED);
    - else if (!strncmp(buf, "disabled", sizeof("disabled")))
    + else if (!strncmp(buf, "disabled", sizeof("disabled") - 1))
    result = tz->ops->set_mode(tz, THERMAL_DEVICE_DISABLED);
    else
    result = -EINVAL;
    --
    1.7.10.rc2.19.gfae9d


    \
     
     \ /
      Last update: 2012-03-30 12:27    [W:2.498 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site