lkml.org 
[lkml]   [2012]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 53/76] ACPI: Evaluate thermal trip points before reading temperature
    Date
    From: Matthew Garrett <mjg@redhat.com>

    An HP laptop (Pavilion G4-1016tx) has the following code in _TMP:

    Store (\_SB.PCI0.LPCB.EC0.RTMP, Local0)
    If (LGreaterEqual (Local0, S4TP))
    {
    Store (One, HTS4)
    }

    S4TP is initialised at 0 and not programmed further until either _HOT or
    _CRT is called. If we evaluate _TMP before the trip points then HTS4 will
    always be set, causing the firmware to generate a message on boot
    complaining that the system shut down because of overheating. The simplest
    solution is just to reverse the checking of trip points and _TMP in thermal
    init.

    Signed-off-by: Matthew Garrett <mjg@redhat.com>
    Signed-off-by: Len Brown <len.brown@intel.com>
    ---
    drivers/acpi/thermal.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/drivers/acpi/thermal.c b/drivers/acpi/thermal.c
    index 48fbc64..7dbebea 100644
    --- a/drivers/acpi/thermal.c
    +++ b/drivers/acpi/thermal.c
    @@ -941,13 +941,13 @@ static int acpi_thermal_get_info(struct acpi_thermal *tz)
    if (!tz)
    return -EINVAL;

    - /* Get temperature [_TMP] (required) */
    - result = acpi_thermal_get_temperature(tz);
    + /* Get trip points [_CRT, _PSV, etc.] (required) */
    + result = acpi_thermal_get_trip_points(tz);
    if (result)
    return result;

    - /* Get trip points [_CRT, _PSV, etc.] (required) */
    - result = acpi_thermal_get_trip_points(tz);
    + /* Get temperature [_TMP] (required) */
    + result = acpi_thermal_get_temperature(tz);
    if (result)
    return result;

    --
    1.7.10.rc2.19.gfae9d


    \
     
     \ /
      Last update: 2012-03-30 12:27    [W:4.337 / U:0.400 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site