Messages in this thread | | | Date | Fri, 30 Mar 2012 01:52:01 +0200 | From | Andi Kleen <> | Subject | Re: [PATCH 05/13] XFS: Fix lock ASSERT on UP |
| |
On Thu, Mar 29, 2012 at 07:21:14PM -0400, Christoph Hellwig wrote: > On Tue, Mar 27, 2012 at 05:47:09PM -0700, Andi Kleen wrote: > > From: Andi Kleen <ak@linux.intel.com> > > > > ASSERT(!spin_is_locked()) doesn't work on UP builds. Replace with a standard > > lockdep_assert_held() > > The "standard" is assert_spin_locked() - which not only is much cheaper > but also has the advantage of working in non-lockdep builds.
But then you have it unconditional, not just on debug builds.
-Andi -- ak@linux.intel.com -- Speaking for myself only.
| |