Messages in this thread | | | Date | Thu, 29 Mar 2012 15:37:41 -0700 | From | Stephen Boyd <> | Subject | Re: [PATCH v6 2/5] Extcon: support generic GPIO extcon driver |
| |
On 02/27/12 04:15, MyungJoo Ham wrote > +static irqreturn_t gpio_irq_handler(int irq, void *dev_id) > +{ > + struct gpio_extcon_data *extcon_data = > + (struct gpio_extcon_data *)dev_id;
Casting from void is unnecessary.
> + > +static int gpio_extcon_probe(struct platform_device *pdev)
__devinit?
> +{ > + struct gpio_extcon_platform_data *pdata = pdev->dev.platform_data; > + struct gpio_extcon_data *extcon_data; > + int ret = 0; [snip] > + return ret; > +} > + > +static int gpio_extcon_remove(struct platform_device *pdev)
__devexit? > +{ > + struct gpio_extcon_data *extcon_data = platform_get_drvdata(pdev); [snip] > +static struct platform_driver gpio_extcon = { > + .probe = gpio_extcon_probe, > + .remove = gpio_extcon_remove,
__devexit_p()? > + .driver = { > + .name = "extcon-gpio", > + .owner = THIS_MODULE, > + }, > +}; > + > +module_platform_driver(gpio_extcon); > + > +MODULE_AUTHOR("Mike Lockwood <lockwood@android.com>"); > +MODULE_DESCRIPTION("GPIO extcon driver"); > +MODULE_LICENSE("GPL"); -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
| |