lkml.org 
[lkml]   [2012]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] percpu: use KERN_CONT in pcpu_dump_alloc_info()
From
Hello, Joe.

On Thu, Mar 29, 2012 at 11:10 AM, Joe Perches <joe@perches.com> wrote:
> Perhaps it's better to try to print lines
> in fewer printks?  Maybe use a line buffer?

What practical difference would that make?

> The first line could be newline terminated.
> "if (alloc)" tests for the individual newlines could be added.
> Why aren't the group widths on separate lines?
> All of the cpu_widths are on the same line as the parent group
> even if that exceeds apl.  Is that what's desired?

I frankly don't remember. I wanted something easy on the eye during
the development to verify the config results and it worked well enough
for me. If you can simplify it, please go ahead and submit a patch.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-29 21:55    [W:0.040 / U:1.836 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site