Messages in this thread | | | Date | Thu, 29 Mar 2012 13:21:56 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH 0/2] tools: Add a toplevel Makefile |
| |
On Wed, Mar 28, 2012 at 07:57:01PM +0200, Borislav Petkov wrote: > On Wed, Mar 28, 2012 at 11:51:25AM +0200, Borislav Petkov wrote: > > I'm currently thinking I want to give the make tools/{perf,help,...} > > approach a try because it is clear that it is a subdir of the kernel src > > tree and it probably could support all the targets we thought about. > > > > Let me play around with it a bit... > > Yeah, nasty. I've almost got it to build a tool when doing > > $ make tools/<toolname> > > but it fails on all the targets which have implicit build rules. (It > seems to build perf fine though because perf Makefile doesn't have > implicit rules for %.c -> %.o etc). And I can see that implicit rules > are being cleared in the toplevel kernel Makefile so that they don't > kick in. > > At this moment, I'm open for hints from the kbuild people, if we use the > toplevel Makefile to build tools/, should all the tools' Makefiles have > explicit rules or ...? Any suggestions are appreciated.
Ok, I got it:
when make is run from the toplevel kernel Makefile, MAKEFLAGS contains '--no-print-directory -RrI /home/boris/kernel/linux-2.6' which is passed down to the sub-make and the '-r' especially turns off the use of built-in implicit rules, thus the problem. Clearing MAKEFLAGS in the sub-make fixes the issue, sorry for the noise.
-- Regards/Gruss, Boris.
Advanced Micro Devices GmbH Einsteinring 24, 85609 Dornach GM: Alberto Bozzo Reg: Dornach, Landkreis Muenchen HRB Nr. 43632 WEEE Registernr: 129 19551
| |