lkml.org 
[lkml]   [2012]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] floppy: revert floppy disable halt warning
(cc some x86 greybeards)

On Sun, 11 Mar 2012 09:38:53 -0700
Stephen Hemminger <shemminger@vyatta.com> wrote:

> Remove the stupid floppy disable halt warning. It is meaningless since
> the API is local to floppy driver. Our boot scripts check for the
> floppy drive, and this causes the warning to trigger every time. This
> confuses support, breaks automated tests that look for backtraces on
> boot, and adds no value.
>
> The message is being displayed to the wrong audience, it looks like it
> was intended as a compromise of a long discussion on LKML about
> supporting older x86 hardware; but users don't know or understand what
> it is saying.
>
> If you want to change halt handling then just fix
> the floppy driver, don't whine about it.
>
> ...
>
> --- a/drivers/block/floppy.c 2012-03-11 09:27:52.866459327 -0700
> +++ b/drivers/block/floppy.c 2012-03-11 09:28:29.286579201 -0700
> @@ -1037,7 +1037,6 @@ static void floppy_disable_hlt(void)
> {
> unsigned long flags;
>
> - WARN_ONCE(1, "floppy_disable_hlt() scheduled for removal in 2012");
> spin_lock_irqsave(&floppy_hlt_lock, flags);
> if (!hlt_disabled) {
> hlt_disabled = 1;

It would have been nice to have provided a pointer to this "long
discussion on LKML". I tried for a while, then gave up.

In my search I came across
http://lkml.indiana.edu/hypermail/linux/kernel/1104.0/00461.html which
does indeed remove all the disable_hlt() code as well as the warning
and the feature-removal-schedule.txt record. Why didn't we merge that?
Why shouldn't we merge that now?




\
 
 \ /
  Last update: 2012-03-28 01:29    [W:0.074 / U:0.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site