Messages in this thread | | | Date | Mon, 26 Mar 2012 12:46:29 +0300 | Subject | Re: [RFC PATCHSET] perf ui: Small preparation on further UI work | From | Pekka Enberg <> |
| |
On Mon, Mar 26, 2012 at 11:51 AM, Namhyung Kim <namhyung.kim@lge.com> wrote: > This is my initial work of UI generalization. As we now get GTK2 support on > perf report, improve setup_browser() to handle it properly so that we can > add various UI specific initialization codes to the function. At least, we > need basic error/warning handlers ASAP to see what's going on when an error > occurred, IMHO. > > I put new file setup.c under ui directory (not under util/ui) and it may or > may not be compiled depending on the system configuration. I think it'd be > better moving generic UI codes to the directory and TUI specific codes to > ui/tui, and so on, so that the util directory doesn't contain any UI codes. > But before proceeding, I'd like to listen to your opinions :).
The series looks good to me:
Acked-by: Pekka Enberg <penberg@kernel.org>
Thanks!
| |