lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4] x86, olpc: add debugfs interface for EC commands

* Andrew Morton <akpm@linux-foundation.org> wrote:

> > Signed-off-by: Daniel Drake <dsd@laptop.org>
> > Originally-from: Paul Fox <pgf@laptop.org>
> > Cc: Ingo Molnar <mingo@elte.hu>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Andres Salomon <dilinger@queued.net>
> >
> > ...
> >
> > v4: really fix sign-off tags
>
> s/fix/break/? "Originally-from" is not a recognised tag. If this code
> is based upon an earlier version from Paul then Signed-off-by: is
> correct.

No, the original ordering was *not* correct:

From: Daniel Drake <dsd@laptop.org>

[...]

Signed-off-by: Daniel Drake <dsd@laptop.org>
Signed-off-by: Paul Fox <pgf@laptop.org>

In the previous discussion we had I explained what the rules for
signoffs are. Let me quote Linus as well:

" The sign-off chain should be very simple: the first person
to sign off should be the author, and the last person to
sign off should be the committer. "

https://lkml.org/lkml/2012/3/22/489

This is not true for this patch, because the first signoff does
not match the 'From:' line (author).

Nor is the last signoff the committer - i.e. the person sending
me this patch to apply. Every maintainer along the route adds a
signoff to the tail if it's propagated via email, or does a
merge commit if it's a pull.

If Daniel sends me a patch he should be the last signoff. If he
authored the patch then he should also be the first (and, by
implication, only) signoff. Signed-off-by does not recognize
multiple authorship - that has to be written into the changelog,
added via another type of tag - either approach is fine to me.

What I cannot do is to apply patches that have visibly broken
signoff chains.

Thanks,

Ingo


\
 
 \ /
  Last update: 2012-03-27 01:17    [W:0.102 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site