Messages in this thread | | | Date | Mon, 26 Mar 2012 11:42:17 -0700 | From | Greg KH <> | Subject | Re: [PATCH 0/6] firmware_class: Fix problems with usermodehelper test |
| |
On Mon, Mar 26, 2012 at 12:00:34AM +0200, Rafael J. Wysocki wrote: > Hi all, > > The following series of patches fixes two problems with > request_firmware() and request_firmware_nowait() resulting from commit > a144c6a6c924aa1da04dd77fb84b89927354fdff > > PM: Print a warning if firmware is requested when tasks are frozen > > The first problem is that request_firmware_nowait() may fail if it happens > to run in parallel with system suspend. It should't fail in such situations > and that is addressed by the first three patches (that code has been discussed > with Linus at al already). > > The second issue is that request_firmware() may be called in a thread which > isn't related to system suspend and if suspend happens exactly at that time, > request_firmware() will fail (and print a scary warning), although it shouldn't. > This problem is addressed by the remaining three patches, which are new.
At first glance, they all look good to me, thanks for doing this work: Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
I'm guessing this will go in through one of your trees, right?
thanks,
greg k-h
| |