lkml.org 
[lkml]   [2012]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/6] firmware_class: Fix problems with usermodehelper test
On Mon, Mar 26, 2012 at 12:00:34AM +0200, Rafael J. Wysocki wrote:
> Hi all,
>
> The following series of patches fixes two problems with
> request_firmware() and request_firmware_nowait() resulting from commit
> a144c6a6c924aa1da04dd77fb84b89927354fdff
>
> PM: Print a warning if firmware is requested when tasks are frozen
>
> The first problem is that request_firmware_nowait() may fail if it happens
> to run in parallel with system suspend. It should't fail in such situations
> and that is addressed by the first three patches (that code has been discussed
> with Linus at al already).
>
> The second issue is that request_firmware() may be called in a thread which
> isn't related to system suspend and if suspend happens exactly at that time,
> request_firmware() will fail (and print a scary warning), although it shouldn't.
> This problem is addressed by the remaining three patches, which are new.

At first glance, they all look good to me, thanks for doing this work:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

I'm guessing this will go in through one of your trees, right?

thanks,

greg k-h


\
 
 \ /
  Last update: 2012-03-26 20:45    [W:0.756 / U:0.604 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site