lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 19/20 v2] sparc/mm/fault_32.c: Port OOM changes to do_sparc_fault
From
From: Kautuk Consul <consul.kautuk@gmail.com>
Date: Sun, 25 Mar 2012 13:58:35 -0400

> + unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
> + (write ? FAULT_FLAG_WRITE : 0));

Still indented wrong, it should be:

unsigned int flags = (FAULT_FLAG_ALLOW_RETRY | FAULT_FLAG_KILLABLE |
(write ? FAULT_FLAG_WRITE : 0));

The second line must have the openning parenthesis line up with
the column after the openning parenthesis on the first line. Do
not use only tabs to indent this stuff, line it up properly.

You need to use tabs and spaces to line it up. Use something like
emacs's C-mode to help you if you can't do it right by hand.

> + perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ,
> + 1, regs, address);

Still wrong, for the same exact reason.

I went out of my way to reply to your private email (which I usually
ignore, you should never email developers privately) and you didn't
even listen to the feedback I gave you.


\
 
 \ /
  Last update: 2012-03-25 21:07    [W:0.046 / U:0.464 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site