lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRE: [PATCH v3] regulator: Add TPS65090 regulator driver
> >
> > TPS65090 PMIC from TI consists of 3 step down converters,
> > 2 always on LDOs and 7 current limited load switches. The
> > output voltages are ON/OFF controllable and are meant to
> > supply power to the components on target board.
>
> Applied, but...
>
> > + rdev = regulator_register(&ri->desc, &pdev->dev,
> > + &tps_pdata->regulator, ri, NULL);
> > + if (IS_ERR_OR_NULL(rdev)) {
>
> ...please submit an incremental patch changing this to plain IS_ERR(),
> regulator_register() only returns error pointers. Note that no other
> regulator drivers do this check.
Thanks Mark, for applying this patch.
As Axel already provided a patch to fix this, Acked on his patch.


\
 
 \ /
  Last update: 2012-03-26 05:55    [W:0.046 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site