lkml.org 
[lkml]   [2012]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: last fs/proc/array.c change
(2012/03/24 21:26), Ulrich Drepper wrote:


> See the second to last seq_put_decimal_ull. This is a copy&paste
> mistake since given the original format it should read
>
> + seq_put_decimal_ull(m, ' ', data);
>
> (i.e., data instead of text).

Thank you for finding..

==
Subject: [PATCH] proc: fix /proc/statm

The patch 'procfs: speed up /proc/pid/stat, statm' breaks /proc/statm
and 'text' is printed twice by mistake.

Reported-by: drepper@gmail.com
Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
---
fs/proc/array.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/proc/array.c b/fs/proc/array.c
index fbb53c2..f9bd395 100644
--- a/fs/proc/array.c
+++ b/fs/proc/array.c
@@ -550,7 +550,7 @@ int proc_pid_statm(struct seq_file *m, struct pid_namespace *ns,
seq_put_decimal_ull(m, ' ', shared);
seq_put_decimal_ull(m, ' ', text);
seq_put_decimal_ull(m, ' ', 0);
- seq_put_decimal_ull(m, ' ', text);
+ seq_put_decimal_ull(m, ' ', data);
seq_put_decimal_ull(m, ' ', 0);
seq_putc(m, '\n');

--
1.7.4.1



\
 
 \ /
  Last update: 2012-03-26 02:57    [W:0.034 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site