Messages in this thread | | | Date | Thu, 22 Mar 2012 15:15:40 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 1/3] genirq: Get rid of unneeded force parameter in irq_finalize_oneshot() |
| |
On Thu, 22 Mar 2012, Alexander Gordeev wrote:
> On Thu, Mar 22, 2012 at 11:32:26AM +0100, Thomas Gleixner wrote: > > Wrong. > > > > CPU 0 CPU 1 > > > > do_exit() > > check(PF_EXITING) > > set_bit(IRQTF_RUNTHREAD) > > ... > > set(PF_EXITING) > > exit_irq_thread() > > Thomas, > > Did not you pick this code with 7140ea1 commit? > > @@ -845,6 +842,13 @@ void exit_irq_thread(void) > > desc = irq_to_desc(action->irq); > > + /* > + * If IRQTF_RUNTHREAD is set, we need to decrement > + * desc->threads_active and wake possible waiters. > + */ > + if (test_and_clear_bit(IRQTF_RUNTHREAD, &action->thread_flags)) > + wake_threads_waitq(desc); > +
Gah crap. Was looking on the wrong branch. That's what you get for looking at patches before coffee hit brain.
Thanks,
tglx
| |