Messages in this thread | | | Date | Wed, 21 Mar 2012 09:38:42 -0500 | From | Seth Forshee <> | Subject | Re: [PATCH v4 0/2] Add driver for Apple gmux device |
| |
On Wed, Mar 21, 2012 at 08:36:47AM -0400, Shea Levy wrote: > Hi Seth, > > On 03/16/2012 03:41 PM, Seth Forshee wrote: > >Apple laptops with hybrid graphics have a device named gmux that is used > >for switching between GPUs and backlight control. On many models this is > >the only reliable method for controlling the backlight. > > > >This series adds initial support for the gmux device, along with > >anciallary support for disabling apple_bl when the gmux device is > >detected. Initially only backlight control is supported. > > > > > > I've done some basic testing on my MBP 5,3 (just setting a few > brightness levels, nothing fancy), and it all works, so feel free to > add my basic > > Tested-by: Shea Levy <shea@shealevy.com> > > if you wish. Please let me know if you need testing for future gmux > features.
Thanks for testing! Matthew has already merged the patch to his tree though, so I won't be able to add your tag.
> A few questions: > * I'm using nouveau, and with the gmux I have both > gmux_backlight and nv_backlight (which never worked) in > /sys/class/backlight, is this expected?
That's a better question for the nouveau developers. nouveau has some criteria it uses to determine whether or not it should supply a backlight device, and apparently that's all passing even though the backlight control doesn't work.
> * Is there anything I can do to test the backlight interface in > addition to setting brightness levels?
The testing you've already done is sufficient.
> * Besides the sysfs backlight interface, are there any other > userspace-visible changes your driver makes that I should test?
Not at this time, no.
Thanks, Seth
| |