Messages in this thread | | | Date | Wed, 21 Mar 2012 09:28:43 +0900 | From | Minchan Kim <> | Subject | Re: [PATCH] mm: forbid lumpy-reclaim in shrink_active_list() |
| |
On Mon, Mar 19, 2012 at 01:18:21PM +0400, Konstantin Khlebnikov wrote: > This patch reset reclaim mode in shrink_active_list() to RECLAIM_MODE_SINGLE | RECLAIM_MODE_ASYNC. > (sync/async sign is used only in shrink_page_list and does not affect shrink_active_list) > > Currenly shrink_active_list() sometimes works in lumpy-reclaim mode, > if RECLAIM_MODE_LUMPYRECLAIM left over from earlier shrink_inactive_list(). > Meanwhile, in age_active_anon() sc->reclaim_mode is totally zero. > So, current behavior is too complex and confusing, all this looks like bug. > > In general, shrink_active_list() populate inactive list for next shrink_inactive_list(). > Lumpy shring_inactive_list() isolate pages around choosen one from both active and > inactive lists. So, there no reasons for lumpy-isolation in shrink_active_list() > > Proposed-by: Hugh Dickins <hughd@google.com> > Link: https://lkml.org/lkml/2012/3/15/583 > Signed-off-by: Konstantin Khlebnikov <khlebnikov@openvz.org>
Acked-by: Minchan Kim <minchan@kernel.org>
| |