Messages in this thread | | | Date | Tue, 20 Mar 2012 22:17:24 +0100 | From | Andrea Arcangeli <> | Subject | Re: [PATCH] autonuma: release page_table_lock in scanning pmd |
| |
On Tue, Mar 20, 2012 at 08:30:48PM +0800, Hillf Danton wrote: > Only for unlikely corner case, unlock is added to pair lock. > > Signed-off-by: Hillf Danton <dhillf@gmail.com> > --- > > --- a/mm/autonuma.c Sat Mar 17 11:01:50 2012 > +++ b/mm/autonuma.c Tue Mar 20 19:58:44 2012 > @@ -522,7 +522,8 @@ static int knumad_scan_pmd(struct mm_str > spin_unlock(&mm->page_table_lock); > goto out; > } > - } > + } else > + spin_unlock(&mm->page_table_lock); > } > > VM_BUG_ON(!pmd_present(*pmd));
I'm impressed by how fast you found these bugs.
Thanks a lot, applied! Andrea
| |