Messages in this thread | | | Date | Tue, 20 Mar 2012 09:02:28 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 09/10] cgroup: introduce struct cfent |
| |
On Tue, Mar 20, 2012 at 06:05:29PM +0400, Glauber Costa wrote: > On 03/17/2012 03:36 AM, Tejun Heo wrote: > >+static void cgroup_clear_directory(struct dentry *dir) > >+{ > >+ struct cgroup *cgrp = __d_cgrp(dir); > >+ > >+ while (!list_empty(&cgrp->files)) > >+ cgroup_rm_file(cgrp, NULL); > >+ WARN_ON_ONCE(!list_empty(&dir->d_subdirs)); > > } > > > I am hitting this warning here under pretty much normal conditions. > You forgot to account for trivial directories like "." > > I'll send a patch ontop of what you have.
Heh, yeah, I hit that yesterday too and was gonna look into that today. Is the patch coming? :)
Thanks.
-- tejun
| |