Messages in this thread | | | Date | Tue, 20 Mar 2012 08:13:35 -0700 | From | Nick Dyer <> | Subject | Re: [PATCH 12/20] Input: atmel_mxt_ts - simplify event reporting |
| |
Daniel Kurtz wrote: > Instead of carrying around per-finger state in the driver instance, just > report each finger as it arrives to the input layer, and let the input > layer (evdev) hold the event state (which it does anyway). > > Also, the atmel pad reports "amplitude", which is reported to userspace > using the "PRESSURE" event type. The variables now reflect this. > > Note: this driver does not really do MT-B properly. Each input report > (a goup of input events followed by a SYN_REPORT) only contains data for > a single contact. When multiple fingers are present on a device, each is > properly reported in its own MT_SLOT. However, there is only ever one > MT_SLOT per SYN_REPORT. This is fixed in a subsequent patch. > > Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
This seems to be a good improvement, assuming it is valid. Which platforms have you tested it on?
-- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk
| |