Messages in this thread | | | Date | Tue, 20 Mar 2012 09:08:59 -0500 (CDT) | From | Christoph Lameter <> | Subject | Re: [RFC PATCH 1/6] kenrel.h: add ALIGN_OF_LAST_BIT() |
| |
On Tue, 20 Mar 2012, Alexey Dobriyan wrote:
> >> +#define ALIGN_OF_LAST_BIT(x) ((((x)^((x) - 1))>>1) + 1) > > > > > > Wouldn't ALIGNMENT() be less confusing? After all, that's what this macro is > > calculating, right? Alignment of given address. > > Bits do not have alignment because they aren't directly addressable. > Can you hardcode this sequence with comment, because it looks too > special for macro.
Some sane naming please. This is confusing.
| |