Messages in this thread | | | Date | Tue, 20 Mar 2012 13:21:16 +0100 | Subject | Re: [PATCH 5/8] pinctrl: core device tree mapping table parsing support | From | Linus Walleij <> |
| |
On Fri, Mar 16, 2012 at 9:54 PM, Stephen Warren <swarren@wwwdotorg.org> wrote:
> During pinctrl_get(), if the client device has a device tree node, look > for the common pinctrl properties there. If found, parse the referenced > device tree nodes, with the help of the pinctrl drivers, and generate > mapping table entries from them. > > During pinctrl_put(), free any results of device tree parsing. > > Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Can we have it in a separate file like devicetree.[c|h] and some stubs in the .h file for platforms that does not select CONFIG_OF?
This:
+static int register_mappings(struct pinctrl_map const *maps, unsigned num_maps, + bool dup, bool locked)
Instead of making this static, move the prototype to core.h and use that from devicetree.c.
One rationale: the day after tomorrow we will have to get configs from ACPI, UEFI and what not.
Apart from that I like the looks of this thing!
Yours, Linus Walleij
| |