Messages in this thread | | | Subject | Re: [PATCH 2/4] compat: backport work_busy() | From | Johannes Berg <> | Date | Tue, 20 Mar 2012 13:07:03 +0100 |
| |
On Mon, 2012-03-19 at 20:26 -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" <mcgrof@frijolero.org> > > Best we can do is just tell the users of we are WORK_BUSY_PENDING > for older kernels. The ckmake log:
[...]
> + * Test whether @work is currently pending or running. There is no > + * synchronization around this function and the test result is > + * unreliable and only useful as advisory hints or for debugging. > + * Especially for reentrant wqs, the pending state might hide the > + * running state.
What's this needed for? It seems if it's used only for hints/debugging we should not need the function, or possibly simply return some pointless combination like -1?
johannes
| |