Messages in this thread | | | Date | Fri, 02 Mar 2012 10:28:29 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [RESUBMIT] [PATCH] Use BIOS Keyboard variable to set Numlock |
| |
On 03/02/2012 09:53 AM, Joshua C. wrote: > > I thought about your idea for separating the platform specific code in > another file. It will make the code more modular but at the end we're > talking about a single function that flips a single bit. I really > don't see any real benefit from defining it in a separate file. It > makes (from my point of view) reading the file just more difficult. > That's why I decided to return the platform specific code back where > it originally was and only modifiy the x86 code. So I can keep the > changes at minimum. I'll post the patch later today and cc the tty > maintainer. Thanks for the help and the ideas. >
Yeah, it seems a bit excessive in this case.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |