Messages in this thread | | | Date | Fri, 2 Mar 2012 10:08:48 -0800 | From | Tony Lindgren <> | Subject | Re: [PATCH 1/4] gpiolib: Add gpiochip_find_by_name() and gpio_find_by_chip_name() |
| |
* Tony Lindgren <tony@atomide.com> [120302 08:31]: > * Grant Likely <grant.likely@secretlab.ca> [120302 01:00]: > > On Thu, 01 Mar 2012 10:55:24 -0800, Tony Lindgren <tony@atomide.com> wrote: > > > + > > > +/** > > > + * gpiochip_find_by_name() - iterator for locating a gpio_chip by name > > > + * @name: name of the gpio_chip > > > + * > > > + * Similar to bus_find_device_by_name. It returns a reference to the > > > + * first gpio_chip with matching name. It ignores NULL and empty names. > > > + * If you need to do something more complex, then use gpiochip_find. > > > + */ > > > +struct gpio_chip *gpiochip_find_by_name(const char *name) > > > +{ > > > + if (!name || !strcmp(name, "")) > > > + return NULL; > > > + > > > + return gpiochip_find((void *)name, match_name); > > > > Nasty cast. Can the signature for gpiochip_find be changed to accept > > a (const void *)? > > I think so, this too comes from the bus code.
Looks like it can't be const as of_node_to_gpiochip uses it with a struct device_node * that for of_get_named_gpio_flags comes from of_parse_phandle_with_args.
Regards,
Tony
| |