lkml.org 
[lkml]   [2012]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: 3.3.0-rc5: OOps in dql_completed (Broadcom tg3 driver)
From
Date
Le jeudi 01 mars 2012 à 15:13 -0600, Christoph Lameter a écrit :
> Dell R620. 2x 2.9Ghz Sandybridge
>
> Sadly I could only get a screenshot and the top of the dump has scrolled
> off the system.
>

Thanks Christoph for this report.

Tom, dql_queued() assumes caller checked availability in the queue with
dql_avail(), but its not the case if tg3_tso_bug() is called.

do {
nskb = segs;
segs = segs->next;
nskb->next = NULL;
tg3_start_xmit(nskb, tp->dev);
} while (segs);

In case we hit BQL limit in one of the tg3_start_xmit() calls, we should
'abort' the following ones, dont you think ?

Or maybe thats irrelevant, and only dql_queued() comment is wrong.

Thanks


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2012-03-02 15:33    [W:0.048 / U:0.608 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site