Messages in this thread | | | Date | Mon, 19 Mar 2012 19:28:12 -0700 | From | Andi Kleen <> | Subject | Re: [PATCH 05/11] XFS: Fix lock ASSERT on UP |
| |
> So this means we only ever check that the spinlock is held when > lockdep is turned on instead of whenever CONFIG_XFS_DEBUG is set?
You should regularly test with lockdep anyways. If you don't you clearly have a testing gap. lockdep is likely to find many more locking bugs than any of your very sparse manual annotations.
> That means it will rarely get checked during development instead of > all the time. That's not an improvement IMO....
It's an improvement that an !CONFIG_SMP && CONFIG_XFS_DEBUG kernel will not blow up anymore.
-Andi
| |