Messages in this thread | | | Date | Mon, 19 Mar 2012 11:31:34 -0400 | From | Ted Ts'o <> | Subject | Re: [PATCH 2/9] ext4: Use pr_fmt and pr_<level> |
| |
On Mon, Mar 19, 2012 at 01:12:11AM -0400, David Miller wrote: > > It also allows you to modify pr_fmt at the top of the file or > elsewhere and have it influence the output, as just one example > of how it's better. > > As a maintainer you can only take one of two positions: > > 1) Accept all properly written patches that convert code over to use > the new and recommended way of doing things, such as pr_info() et > al.
Recommended by *who*?!? Who dictated that this is the best way to go?
And in the past we've always allowed for local variations of style; it's never been a strict style nazism. Linus has always given maintainers latitude and has frowned on patch churn for churn's sake.
For goodness sake we still have get_fs() and set_fs() in the kernel code even though we haven't used the actual fs segment register in over a decade.
And we're arguing over "there must be only one true logging interface?!?". This isn't Highlander.
- Ted
| |