lkml.org 
[lkml]   [2012]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] wl12xx: fix DMA-API-related warnings
Date
On Saturday 17 March 2012, Mircea Gherzan wrote:
> int wl1271_event_handle(struct wl1271 *wl, u8 mbox_num)
> {
> - struct event_mailbox mbox;
> - int ret;
> + struct event_mailbox *mbox;
> + int ret = 0;
>
> wl1271_debug(DEBUG_EVENT, "EVENT on mbox %d", mbox_num);
>
> if (mbox_num > 1)
> return -EINVAL;
>
> + /* no GFP_ATOMIC: we're called from the threaded IRQ handler */
> + mbox = kmalloc(sizeof(*mbox), GFP_DMA);
> +
> /* first we read the mbox descriptor */
> - wl1271_read(wl, wl->mbox_ptr[mbox_num], &mbox,
> - sizeof(struct event_mailbox), false);
> + wl1271_read(wl, wl->mbox_ptr[mbox_num], mbox, sizeof(*mbox), false);
>
> /* process the descriptor */
> - ret = wl1271_event_process(wl, &mbox);
> + ret = wl1271_event_process(wl, mbox);
> if (ret < 0)
> - return ret;
> + goto out;
>
> /* then we let the firmware know it can go on...*/
> wl1271_write32(wl, ACX_REG_INTERRUPT_TRIG, INTR_TRIG_EVENT_ACK);
>
> - return 0;
> +out:
> + kfree(mbox);
> + return ret;
> }

I think it would be better here to put another field into struct wl1271 to hold
the mailbox. There is no point allocating and freeing the field every time
you get into the interrupt handler.

Arnd


\
 
 \ /
  Last update: 2012-03-17 17:47    [W:1.976 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site