Messages in this thread Patch in this message | | | From | "Du, Alek" <> | Subject | RE: [PATCH] tty: hold lock across tty buffer finding and buffer filling | Date | Fri, 16 Mar 2012 11:33:28 +0000 |
| |
Isn't this the nature of "flush" ? If the driver is trying to insert chars to tty buffer, while the app is going to flush the buffer, or shutdown the port, that's quite nature that those data gone. Why should I care ?
Sorry, you missed the point of this patch.
Thanks, Alek -----Original Message----- From: Jiri Slaby [mailto:jirislaby@gmail.com] On Behalf Of Jiri Slaby Sent: Friday, March 16, 2012 6:22 PM To: Du, Alek Cc: Jiri Slaby; Alan Cox; Tu, Xiaobing; linux-kernel@vger.kernel.org; gregkh@linuxfoundation.org; Zhang, Yanmin; Zuo, Jiao Subject: Re: [PATCH] tty: hold lock across tty buffer finding and buffer filling
On 03/16/2012 11:08 AM, Du, Alek wrote: > If you really look at the original patch from Xiaobing, the > tty_prepare_flip_string is also patched :-) Actually it fills up all > the possible spin_lock gaps in tty_buffer.c > > > @@ -344,13 +375,20 @@ EXPORT_SYMBOL(tty_schedule_flip); int tty_prepare_flip_string(struct tty_struct *tty, unsigned char **chars, > size_t size) > { > - int space = tty_buffer_request_room(tty, size); > + int space; > + unsigned long flags; > + struct tty_buffer *tb; > + > + spin_lock_irqsave(&tty->buf.lock, flags); > + space = __tty_buffer_request_room(tty, size); > + > + tb = tty->buf.tail; > if (likely(space)) { > - struct tty_buffer *tb = tty->buf.tail; > *chars = tb->char_buf_ptr + tb->used; ^^^^^^ This is returned to the caller. And it writes to that. And it may be gone as soon as the lock is unlocked below.
> memset(tb->flag_buf_ptr + tb->used, TTY_NORMAL, space); > tb->used += space; > } > + spin_unlock_irqrestore(&tty->buf.lock, flags); > return space; > }
thanks, -- js suse labs
| |