Messages in this thread | | | Date | Thu, 15 Mar 2012 17:57:16 -0700 | Subject | Re: [PATCH] Added separate apic_id_valid() functions for selected apic drivers | From | Yinghai Lu <> |
| |
On Thu, Mar 15, 2012 at 5:13 PM, Suresh Siddha <suresh.b.siddha@intel.com> wrote: > On Fri, 2012-03-16 at 01:07 +0100, Steffen Persvold wrote: >> diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c >> index 1c1c4f4..7efd0c6 100644 >> --- a/arch/x86/mm/srat.c >> +++ b/arch/x86/mm/srat.c >> @@ -69,12 +69,6 @@ acpi_numa_x2apic_affinity_init(struct acpi_srat_x2apic_cpu_affinity *pa) >> if ((pa->flags & ACPI_SRAT_CPU_ENABLED) == 0) >> return; >> pxm = pa->proximity_domain; >> - apic_id = pa->apic_id; >> - if (!cpu_has_x2apic && (apic_id >= 0xff)) { > > not sure why you removed this. Shouldn't this be replaced with > apic->apic_id_valid() check? >
yes, it should change to apic->apic_id_valid().
in arch/x86/kernel/setup.c, early_acpi_boot_init() calling will probe and install right apic.
Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |