Messages in this thread | | | Date | Thu, 15 Mar 2012 17:35:23 -0700 | From | Greg KH <> | Subject | Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver |
| |
On Fri, Mar 16, 2012 at 01:30:43AM +0100, Mircea Gherzan wrote: > > This is what I get now (with no debug) when loading the btwilink module > that uses ti-st: > > [ 129.567382] (stk) :change remote baud rate command in firmware > [ 129.573577] (stk) :skipping the wait event of change remote baud > > This is: > 1. too "verbose" => these 2 prints should belong to debug > 2. poorly formated > 3. not telling me which driver generated this output > 4. not giving me the version of the firmware that was loaded. > > To address 2 and 3, please remove the the "(stc)" / "(stk)" prefixes and > use instead the quite widespread prefix KBUILD_MODNAME ": "
No, just use the proper dev_*() functions instead, it will tell you exactly what driver and device emitted the message, that is what it is there for.
thanks,
greg k-h
| |