Messages in this thread | | | Date | Thu, 15 Mar 2012 14:23:38 -0700 | From | "" <> | Subject | Re: [PATCH] ti-st: Enhange logging for Shared Transport - TI driver |
| |
On Thu, Mar 15, 2012 at 11:17:25PM +0200, Alexandra Sava wrote: > On 15 March 2012 23:10, Alexandra Sava <alexandrasava18@gmail.com> wrote: > > On 15 March 2012 22:29, Savoy, Pavan <pavan_savoy@ti.com> wrote: > >> Daniel Baluta wrote: > >>> Adding Greg's new email address. > >>> > >>> On Thu, Mar 15, 2012 at 8:26 PM, <alexandrasava18@gmail.com> wrote: > >>>> From: Alexandra Sava <alexandrasava18@gmail.com> > >>>> > >>>> * added new module parameter named debug_mask to control displayed > >>>> messages verbosity > >>>> * the logging mechanism is enabled via CONFIG_TI_ST_DEBUG Kconfig > >>>> option > >> > >> Any specific reason you want to have this ? Custom logging ? > >> Also please fix the spelling in the subject line. > >> > > > > The logging for this driver is too verbose, and I thought it would be > > better to implement a configurable mechanism which can enable/disable > > the log messages (not only via the global CONFIG_DYNAMIC_DEBUG). > > So, I think there are two ways: > > The logging for this driver is too verbose, and I thought it would be > better to implement a configurable mechanism which can enable/disable > the log messages (not only via the global CONFIG_DYNAMIC_DEBUG). > So, I think there are two ways: > 1. keep pr_debug but reduce the amount of messages
That's probably the best, you aren't needing almost all of them anymore now that the driver is working.
> 2. make the logs configurabile via CONFIG_TI_SI_DEBUG
No, don't do this, no one will enable it.
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |