Messages in this thread | | | Date | Thu, 15 Mar 2012 13:26:33 -0700 | From | "" <> | Subject | Re: [PATCH] tty: hold lock across tty buffer finding and buffer filling |
| |
On Thu, Mar 15, 2012 at 02:06:43AM +0000, Tu, Xiaobing wrote: > From: Xiaobing Tu <xiaobing.tu@intel.com> > > tty_buffer_request_room is well protected, but while after it returns, > it releases the port->lock. tty->buf.tail might be modified > by either irq handler or other threads. The patch adds more protection > by holding the lock across tty buffer finding and buffer filling. > > Signed-off-by: Alek Du <alek.du@intel.com> > Signed-off-by: Xiaobing Tu <xiaobing.tu@intel.com> > --- > drivers/tty/tty_buffer.c | 85 +++++++++++++++++++++++++++++++++++----------- > 1 files changed, 65 insertions(+), 20 deletions(-) > mode change 100644 => 100755 drivers/tty/tty_buffer.c > > diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c > old mode 100644 > new mode 100755
What? Why would you change the mode of the file to be executable?
Also, your patch introduces a bunch of trailing whitespace, please run it through scripts/checkpatch.pl and fix those issues before resending it.
thanks,
greg k-h
| |