lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] usb/ub: deprecate & schedule for removal the "Low Performance USB Block" driver
On Thu, Mar 15, 2012 at 09:33:31AM -0600, Pete Zaitcev wrote:
> On Wed, 14 Mar 2012 21:52:51 +0100
> Sebastian Andrzej Siewior <sebastian@breakpoint.cc> wrote:
>
> > +What: Low Performance USB Block driver ("CONFIG_BLK_DEV_UB")
> > +When: 3.6
>
> ACK
>
> > + does not use libusual which holds various workarounds for
> > + certain buggy devices.
>
> Although the above is false, and ub actually started libusual,
> I don't mind. It's a transient notice anyway. Once ub is gone,
> libusual can be folded back into usb-storage.

There might be an miss understanding here. For instance in
drivers/usb/storage/unusual_devs.h we have an entry like:

|UNUSUAL_DEV( 0x03f0, 0x4002, 0x0001, 0x0001,
| "HP",
| "PhotoSmart R707",
| USB_SC_DEVICE, USB_PR_DEVICE, NULL, US_FL_FIX_CAPACITY),
|

That US_FL_FIX_CAPACITY is used later in scsiglue.c to set sdev->fix_capacity
which is then used by sd_read_capacity() to substract one sector from the
final size.
In ub I see ub_sync_read_cap() and I don't see a change. Was my wording wrong
or is this something else?

> -- Pete

Sebastian


\
 
 \ /
  Last update: 2012-03-15 18:59    [W:0.061 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site