lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power_supply: Convert power_supply i2c drivers to module_i2c_driver
On Sat, Jan 21, 2012 at 02:42:54PM +0800, Axel Lin wrote:
> Factor out some boilerplate code for i2c driver registration
> into module_i2c_driver.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> Cc: Ryan Mallon <rmallon@gmail.com>
> Cc: Woogyom Kim <milo.kim@ti.com>
> Cc: Daniel Jeong <daniel.jeong@ti.com>
> Cc: Minkyu Kang <mk7.kang@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Rhyland Klein <rklein@nvidia.com>
> Cc: Peter Edwards <sweetlilmre@gmail.com>
> ---
> drivers/power/ds2782_battery.c | 12 +-----------
> drivers/power/lp8727_charger.c | 13 +------------
> drivers/power/max17040_battery.c | 12 +-----------
> drivers/power/max17042_battery.c | 12 +-----------
> drivers/power/sbs-battery.c | 12 +-----------
> drivers/power/z2_battery.c | 13 +------------
> 6 files changed, 6 insertions(+), 68 deletions(-)
>
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index bfbce5d..6e3d76a 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -404,17 +404,7 @@ static struct i2c_driver ds278x_battery_driver = {
> .id_table = ds278x_id,
> };
>

Cosmetic nit: I don't think that there should be an empty line.
I.e. it should be just as we do with MODULE_DEVICE_TABLE and
other macros:

static const struct i2c_device_id .. = {
...
};
MODULE_DEVICE_TABLE(...)

static struct i2c_driver ... = {
...
};
module_i2c_driver(...);

I fixed it up and applied the patch. Thanks!

--
Anton Vorontsov
Email: cbouatmailru@gmail.com


\
 
 \ /
  Last update: 2012-03-15 18:17    [W:0.074 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site