Messages in this thread | | | Date | Wed, 14 Mar 2012 23:18:26 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator |
| |
On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:
> > When a c programmer sees a variable called "i", he solidly expects it > > to have type "int". Please choose a better name for this guy! > > Perferably something which helps the reader understand what the > > variable's role is. > > =) Ok, I can make it "int"
This should be an unsigned type - negative values are meaningless here.
And "i" is simply a poor identifier. A good identifier is one which communicates the variable's role.
| |