lkml.org 
[lkml]   [2012]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] radix-tree: introduce bit-optimized iterator
On Thu, 15 Mar 2012 09:51:03 +0400 Konstantin Khlebnikov <khlebnikov@openvz.org> wrote:

> > When a c programmer sees a variable called "i", he solidly expects it
> > to have type "int". Please choose a better name for this guy!
> > Perferably something which helps the reader understand what the
> > variable's role is.
>
> =) Ok, I can make it "int"

This should be an unsigned type - negative values are meaningless here.

And "i" is simply a poor identifier. A good identifier is one which
communicates the variable's role.



\
 
 \ /
  Last update: 2012-03-15 07:19    [W:0.031 / U:1.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site