Messages in this thread | | | Date | Wed, 14 Mar 2012 18:47:54 -0700 (PDT) | From | Hugh Dickins <> | Subject | Re: [PATCH 3/7 v2] mm: rework __isolate_lru_page() file/anon filter |
| |
On Sat, 10 Mar 2012, Konstantin Khlebnikov wrote: > Konstantin Khlebnikov wrote: > > > > No, for non-lumpy isolation we don't need this check at all, > > because all pages already picked from right lru list. > > > > I'll send separate patch for this (on top v5 patchset), after meditation =) > > Heh, looks like we don't need these checks at all: > without RECLAIM_MODE_LUMPYRECLAIM we isolate only pages from right lru, > with RECLAIM_MODE_LUMPYRECLAIM we isolate pages from all evictable lru. > Thus we should check only PageUnevictable() on lumpy reclaim.
Yes, those were great simplfying insights: I'm puzzling over why you didn't follow through on them in your otherwise nice 4.5/7, which still involves lru bits in the isolate mode?
Hugh
| |