Messages in this thread | | | Date | Thu, 15 Mar 2012 09:44:24 +0900 | From | Namhyung Kim <> | Subject | Re: [RFC] perf report: Implement symbol filtering on TUI |
| |
Hi,
2012-03-15 8:11 AM, Arun Sharma wrote: > On Wed, Mar 07, 2012 at 10:57:50AM +0900, Namhyung Kim wrote: >> As Ingo requested, symbol filtering feature was missing on TUI. >> Add 's' key to get input from user, and do simple filtering by >> strstr(). To turn filtering off, just enter no name by pressing >> 's' followed by ENTER. > > Why not do this for --stdio as well? > > perf report foo -g graph,0.5,caller -s inclusive --stdio > > will print only the callgraph under foo. > > This works better for me than: > > perf report -s parent -p ^c$ --stdio > > -Arun
Thanks for reviewing and sending the patch.
However this was already fixed on my new patch set. Please see below:
https://lkml.org/lkml/2012/3/13/73
Thanks, Namhyung
> > index 94394f3..607b21b 100644 > --- a/tools/perf/builtin-report.c > +++ b/tools/perf/builtin-report.c > @@ -219,6 +219,8 @@ static int perf_evlist__tty_browse_hists(struct perf_evlist *evlist, > struct hists *hists =&pos->hists; > const char *evname = event_name(pos); > > + hists->symbol_filter_str = rep->symbol_filter_str; > + hists__filter_by_symbol(hists); > hists__fprintf_nr_sample_events(hists, evname, stdout); > hists__fprintf(hists, NULL, false, true, 0, 0, stdout); > fprintf(stdout, "\n\n"); > >
| |