lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v1 2/5] mmc: mxs-mmc: add dt probe support
Date
Dear Dong Aisheng,

> On Wed, Mar 14, 2012 at 01:58:25PM +0800, Marek Vasut wrote:
> > Dear Dong Aisheng,
> >
> > > Signed-off-by: Dong Aisheng <dong.aisheng@linaro.org>
>
> ........
>
> > > +static const struct of_device_id mxs_mmc_dt_ids[] = {
> > > + { .compatible = "fsl,imx23-mmc", .data = NULL, },
> > > + { .compatible = "fsl,imx28-mmc", .data = NULL, },
> >
> > Do you really need two distinct ones here?
>
> Hmm, my original purpose is to put soc difference data in .data
> to remove cpu_is_* function calls in the driver later.
> Do you think if any issue?
>

Well, what's the difference between the interfaces on mx233 and mx28? Is it
something that can't be encoded otherwise? I think they're not so different.

Best regards,
Marek Vasut


\
 
 \ /
  Last update: 2012-03-14 08:11    [W:0.122 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site