lkml.org 
[lkml]   [2012]   [Mar]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tile_edac: Fix the memory controller ID
On 3/12/2012 10:02 AM, Mauro Carvalho Chehab wrote:
> Fix a regression introduced by changeset 7b03829a8ba4:
>
> - mci = edac_mc_alloc(sizeof(struct tile_edac_priv),
> - TILE_EDAC_NR_CSROWS, TILE_EDAC_NR_CHANS, pdev->id);
> + mci = edac_mc_alloc(0, ARRAY_SIZE(layers), layers, false,
> + sizeof(struct tile_edac_priv));
>
> The pdev->id is missing.
>
> Compile-tested only. Btw, in order to compile it, I had to:
>
> 1) comment a header at arch/tile/include/asm/linkage.h:
>
> -#include <feedback.h>
> +//#include <feedback.h>
>
> 2) Use the ./arch/tile/configs/tilegx_defconfig . the tilepro_defconfig
> is broken;
>
> 3) manually enable the EDAC module on it.
>
> Somebody has to fix it ;)
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

You might amend the commit message based on our conversation, but otherwise:

Acked-by: Chris Metcalf <cmetcalf@tilera.com>

Thanks for fixing up the tile EDAC driver, BTW :-)

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com



\
 
 \ /
  Last update: 2012-03-14 20:13    [W:0.461 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site