Messages in this thread | | | Date | Wed, 14 Mar 2012 18:40:20 +0100 | From | Lars-Peter Clausen <> | Subject | Re: [alsa-devel] [PATCH v6] sound/soc/codecs: add LAPIS Semiconductor ML26124 |
| |
On 03/08/2012 03:24 AM, Tomoya MORINAGA wrote: > On Wed, Mar 7, 2012 at 8:48 PM, Mark Brown > <broonie@opensource.wolfsonmicro.com> wrote: >>> If possible, I want to use framework features. However, I judged it is >>> not possible. >>> Let me confirm again. >>> As I said before, all ML26124 registers need to be accessed by >>> different address when read and write. >>> Like below >>> R W >>> $00h $01h Sampling setting >>> $02h $03h PLL setting >>> ... >>> Even so, can I use framework features ? >> No, in which case (to repeat what I said previously) you need to make >> the code *much* clearer so the reader can understand what it is doing >> and why it's having to open code this stuff. > > > thanks.
If this is for all registers, how does stuff like DAPM work, which uses the framework internal update_bits function?
If it's the case that the write address is always read address + 1 you can still use the framework if you set write_flag_mask to 0x01 in your regmap config. In my opinion it even makes sense to shift all the register numbers to the left by one and use a 7/9 instead of a 8/8 addr/reg layout. This will reduce the amount of memory wasted due to holes in the register cache.
| |