Messages in this thread Patch in this message | | | Subject | [PATCH] checkpatch: Suggest pr_<level> over printk(KERN_<LEVEL> | From | Joe Perches <> | Date | Mon, 12 Mar 2012 23:23:03 -0700 |
| |
Suggest the shorter pr_<level> instead of printk(KERN_<LEVEL>.
Prefer to use pr_<level> over bare printks. Prefer to use pr_warn over pr_warning.
Signed-off-by: Joe Perches <joe@perches.com> --- scripts/checkpatch.pl | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 04eb9eb..ac2bbea 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2379,6 +2379,19 @@ sub process { } } + if ($line =~ /\bprintk\s*\(\s*KERN_([A-Z]+)/) { + my $orig = $1; + my $level = lc($orig); + $level = "warn" if ($level eq "warning"); + WARN("PREFER_PR_LEVEL", + "Prefer pr_$level(... to printk(KERN_$1, ...\n" . $herecurr); + } + + if ($line =~ /\bpr_warning\s*\(/) { + WARN("PREFER_PR_LEVEL", + "Prefer pr_warn(... to pr_warning(...\n" . $herecurr); + } + # function brace can't be on same line, except for #defines of do while, # or if closed on same line if (($line=~/$Type\s*$Ident\(.*\).*\s{/) and
| |