lkml.org 
[lkml]   [2012]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net-next] net: ipv4: Standardize prefixes for message logging
From
Date
On Mon, 2012-03-12 at 17:05 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 12 Mar 2012 10:03:32 -0700
> > Add #define pr_fmt(fmt) as appropriate.
> > Add "IPv4: ", "TCP: ", and "IPsec: " to appropriate files.
> > Standardize on "UDPLite: " for appropriate uses.
> > Some prefixes were previously "UDPLITE: " and "UDP-Lite: ".
[]
> Looks good, and applied,

OK. I'll submit a similar change for net/ipv6 in awhile.

> but I left out this hunk:

> > diff --git a/net/ipv4/ipcomp.c b/net/ipv4/ipcomp.c
> > index 63b64c4..56d6768 100644
> > --- a/net/ipv4/ipcomp.c
> > +++ b/net/ipv4/ipcomp.c
> > @@ -13,6 +13,7 @@
> > * - Compression stats.
> > * - Adaptive compression.
> > */
> > +
> > #include <linux/module.h>
> > #include <linux/err.h>
> > #include <linux/rtnetlink.h>
>
> As it seemed accidental, if not gratuitous.

It wasn't accidental, though I could have mentioned it
in the changelog. Most files have a blank line between
an initial block commment and the first #include.

I just do that by habit when looking if a file could
benefit from a #define pr_fmt.

I added a similar blank line to udplite.c, but there
I also added pr_fmt.

cheers, Joe



\
 
 \ /
  Last update: 2012-03-13 01:39    [W:0.047 / U:0.940 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site